[
https://issues.apache.org/jira/browse/GOBBLIN-1366?focusedWorklogId=538782&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-538782
]
ASF GitHub Bot logged work on GOBBLIN-1366:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jan/21 00:47
Start Date: 21/Jan/21 00:47
Worklog Time Spent: 10m
Work Description: aplex commented on a change in pull request #3208:
URL: https://github.com/apache/incubator-gobblin/pull/3208#discussion_r561438129
##########
File path:
gobblin-modules/gobblin-azkaban/src/main/java/org/apache/gobblin/azkaban/AzkabanJobLauncher.java
##########
@@ -112,6 +112,9 @@
private static final String AZKABAN_GOBBLIN_JOB_SLA_IN_SECONDS =
"gobblin.azkaban.SLAInSeconds";
private static final String DEFAULT_AZKABAN_GOBBLIN_JOB_SLA_IN_SECONDS =
"-1"; // No SLA.
+ public static final String GOBBLIN_INITIALIZE_HADOOP_TOKENS =
"gobblin.initializeHadoopTokens";
Review comment:
The property above uses "gobblin.azkaban" prefix. Should we use the same
prefix here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 538782)
Time Spent: 20m (was: 10m)
> Add an option to skip initialization of hadoop tokens in the
> AzkabanJobLauncher
> -------------------------------------------------------------------------------
>
> Key: GOBBLIN-1366
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1366
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Hung Tran
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The AzkabanJobLauncher was changed recently to remove the dependency on the
> job type for determining token initialization.
> This breaks some use cases where no tokens are required.
> Add the gobblin.initializeHadoopTokens option with a default of true to allow
> opting out of token initialization.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
