[
https://issues.apache.org/jira/browse/GOBBLIN-1370?focusedWorklogId=539659&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-539659
]
ASF GitHub Bot logged work on GOBBLIN-1370:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/21 05:56
Start Date: 22/Jan/21 05:56
Worklog Time Spent: 10m
Work Description: jack-moseley commented on a change in pull request
#3211:
URL: https://github.com/apache/incubator-gobblin/pull/3211#discussion_r562279218
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/restli/GobblinServiceFlowExecutionResourceHandler.java
##########
@@ -71,15 +71,14 @@ public FlowExecution get(ComplexResourceKey<FlowStatusId,
EmptyRecord> key) {
}
@Override
- public UpdateResponse resume(ComplexResourceKey<FlowStatusId, EmptyRecord>
key) {
+ public void resume(ComplexResourceKey<FlowStatusId, EmptyRecord> key) {
Review comment:
Not really a reason in particular, restli just gives us the ID as a
`ComplexResourceKey` and at some point we have to call getKey to get the
`FlowStatusId ` from it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 539659)
Time Spent: 1h (was: 50m)
> Make flow resume a restli action instead of partial update
> ----------------------------------------------------------
>
> Key: GOBBLIN-1370
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1370
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
