aplex commented on a change in pull request #3211:
URL: https://github.com/apache/incubator-gobblin/pull/3211#discussion_r562262845
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/restli/GobblinServiceFlowExecutionResourceHandler.java
##########
@@ -71,15 +71,14 @@ public FlowExecution get(ComplexResourceKey<FlowStatusId,
EmptyRecord> key) {
}
@Override
- public UpdateResponse resume(ComplexResourceKey<FlowStatusId, EmptyRecord>
key) {
+ public void resume(ComplexResourceKey<FlowStatusId, EmptyRecord> key) {
Review comment:
What's the reason to use ComplexResourceKey<FlowStatusId, EmptyRecord>
instead of FlowStatusId directly?
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/restli/GobblinServiceFlowExecutionResourceHandler.java
##########
@@ -71,15 +71,14 @@ public FlowExecution get(ComplexResourceKey<FlowStatusId,
EmptyRecord> key) {
}
@Override
- public UpdateResponse resume(ComplexResourceKey<FlowStatusId, EmptyRecord>
key) {
+ public void resume(ComplexResourceKey<FlowStatusId, EmptyRecord> key) {
Review comment:
ok. I see that it's the same in other methods here. Let's keep it
consistent then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
