sv2000 commented on a change in pull request #3207:
URL: https://github.com/apache/incubator-gobblin/pull/3207#discussion_r564880118
##########
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
##########
@@ -24,6 +24,7 @@
import java.nio.ByteBuffer;
import java.util.EnumSet;
import java.util.HashMap;
+import java.util.Iterator;
Review comment:
Unused import?
##########
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnConfigurationKeys.java
##########
@@ -124,4 +126,5 @@
public static final String GOBBLIN_YARN_AZKABAN_CLASS_LOG_LEVELS =
GOBBLIN_YARN_PREFIX + "azkaban.class.logLevels";
//Container classpaths properties
public static final String GOBBLIN_YARN_ADDITIONAL_CLASSPATHS =
GOBBLIN_YARN_PREFIX + "additional.classpaths";
+ public static final String GOBBLIN_YARN_CLASSPATHS = GOBBLIN_YARN_PREFIX +
"classpaths";
Review comment:
Do we need an additional config? Or can we use
gobblin.yarn.additional.classpaths?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
