arjun4084346 commented on a change in pull request #3220:
URL: https://github.com/apache/incubator-gobblin/pull/3220#discussion_r569017978
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -1144,6 +1154,15 @@ private void cleanUp() {
for (String dagId: dagIdstoClean) {
cleanUpDag(dagId);
}
+
+ for (Iterator<Map.Entry<String, Dag<JobExecutionPlan>>> iter =
this.failedDags.entrySet().iterator(); iter.hasNext();) {
Review comment:
This should work. But my only concern is that we are looping over all
the failed dags to check if their clean up time has come at the end of every
DagManager poll cycle. Should we do this in a separate cleaning thread in
DagManager, which runs, say every 1 hour or so?
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -1144,6 +1154,15 @@ private void cleanUp() {
for (String dagId: dagIdstoClean) {
cleanUpDag(dagId);
}
+
+ for (Iterator<Map.Entry<String, Dag<JobExecutionPlan>>> iter =
this.failedDags.entrySet().iterator(); iter.hasNext();) {
Review comment:
The javadoc also says "Because this thread runs in a regular interval,
we should avoid doing repetitive work inside it."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
