[
https://issues.apache.org/jira/browse/GOBBLIN-1387?focusedWorklogId=551059&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-551059
]
ASF GitHub Bot logged work on GOBBLIN-1387:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Feb/21 00:03
Start Date: 11/Feb/21 00:03
Worklog Time Spent: 10m
Work Description: codecov-io edited a comment on pull request #3225:
URL: https://github.com/apache/gobblin/pull/3225#issuecomment-777118518
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3225?src=pr&el=h1)
Report
> Merging
[#3225](https://codecov.io/gh/apache/gobblin/pull/3225?src=pr&el=desc)
(1f189da) into
[master](https://codecov.io/gh/apache/gobblin/commit/f6e063245df709c6981226a98129087cef0f9d4f?el=desc)
(f6e0632) will **increase** coverage by `0.17%`.
> The diff coverage is `62.50%`.
[](https://codecov.io/gh/apache/gobblin/pull/3225?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3225 +/- ##
============================================
+ Coverage 46.18% 46.36% +0.17%
- Complexity 9771 9930 +159
============================================
Files 2019 2030 +11
Lines 77529 78720 +1191
Branches 8608 8755 +147
============================================
+ Hits 35809 36500 +691
- Misses 38386 38820 +434
- Partials 3334 3400 +66
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3225?src=pr&el=tree) |
Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...untime/listeners/EmailNotificationJobListener.java](https://codecov.io/gh/apache/gobblin/pull/3225/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbGlzdGVuZXJzL0VtYWlsTm90aWZpY2F0aW9uSm9iTGlzdGVuZXIuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...in/java/org/apache/gobblin/runtime/JobContext.java](https://codecov.io/gh/apache/gobblin/pull/3225/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvSm9iQ29udGV4dC5qYXZh)
| `76.19% <71.42%> (-0.19%)` | `52.00 <2.00> (+2.00)` | :arrow_down: |
|
[...n/java/org/apache/gobblin/yarn/YarnHelixUtils.java](https://codecov.io/gh/apache/gobblin/pull/3225/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFybkhlbGl4VXRpbHMuamF2YQ==)
| `26.66% <0.00%> (-6.03%)` | `9.00% <0.00%> (+1.00%)` | :arrow_down: |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/gobblin/pull/3225/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `32.23% <0.00%> (-5.79%)` | `12.00% <0.00%> (-2.00%)` | |
|
[...ain/java/org/apache/gobblin/runtime/fork/Fork.java](https://codecov.io/gh/apache/gobblin/pull/3225/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvZm9yay9Gb3JrLmphdmE=)
| `76.30% <0.00%> (-0.31%)` | `73.00% <0.00%> (ø%)` | |
|
[...blin/service/modules/orchestration/DagManager.java](https://codecov.io/gh/apache/gobblin/pull/3225/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXIuamF2YQ==)
| `70.05% <0.00%> (-0.29%)` | `13.00% <0.00%> (ø%)` | |
|
[...main/java/org/apache/gobblin/yarn/YarnService.java](https://codecov.io/gh/apache/gobblin/pull/3225/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFyblNlcnZpY2UuamF2YQ==)
| `14.36% <0.00%> (-0.08%)` | `4.00% <0.00%> (ø%)` | |
|
[...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/gobblin/pull/3225/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
|
[...che/gobblin/yarn/GobblinYarnConfigurationKeys.java](https://codecov.io/gh/apache/gobblin/pull/3225/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5Db25maWd1cmF0aW9uS2V5cy5qYXZh)
| `66.66% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | |
|
[...org/apache/gobblin/iceberg/Utils/IcebergUtils.java](https://codecov.io/gh/apache/gobblin/pull/3225/diff?src=pr&el=tree#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvVXRpbHMvSWNlYmVyZ1V0aWxzLmphdmE=)
| `60.00% <0.00%> (ø)` | `14.00% <0.00%> (?%)` | |
| ... and [26
more](https://codecov.io/gh/apache/gobblin/pull/3225/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3225?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3225?src=pr&el=footer).
Last update
[f6e0632...1f189da](https://codecov.io/gh/apache/gobblin/pull/3225?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 551059)
Time Spent: 40m (was: 0.5h)
> Email Notifications for failures not sending
> --------------------------------------------
>
> Key: GOBBLIN-1387
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1387
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Affects Versions: 0.16.0
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Email notifications look into JOB_FAILURES_KEY, which is set by DatasetState.
> JobContext's reference to it's own jobState is misleading here as it does not
> track dataset state failures (in terms of amounts, only if it is
> passed/failed).
> Add a function to track the dataset state failures from jobContext
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
