[
https://issues.apache.org/jira/browse/GOBBLIN-1397?focusedWorklogId=558731&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-558731
]
ASF GitHub Bot logged work on GOBBLIN-1397:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Feb/21 20:53
Start Date: 26/Feb/21 20:53
Worklog Time Spent: 10m
Work Description: sv2000 commented on a change in pull request #3235:
URL: https://github.com/apache/gobblin/pull/3235#discussion_r583912000
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/kafka/client/AbstractBaseKafkaConsumerClient.java
##########
@@ -54,13 +54,16 @@
private static final int CONFIG_KAFKA_FETCH_REQUEST_MIN_BYTES_DEFAULT = 1024;
public static final String CONFIG_KAFKA_SOCKET_TIMEOUT_VALUE = CONFIG_PREFIX
+ "socketTimeoutMillis";
public static final int CONFIG_KAFKA_SOCKET_TIMEOUT_VALUE_DEFAULT = 30000;
// 30 seconds
+ public static final String CONFIG_ENABLE_SCHEMA_CHECK = CONFIG_PREFIX +
"enableSchemaCheck";
+ public static final boolean ENABLE_SCHEMA_CHECK_DEFAULT = false; // 30
seconds
Review comment:
Remove the comment "// 30 seconds".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 558731)
Time Spent: 20m (was: 10m)
> Make schema check configurable in Kafka Consumer Client
> -------------------------------------------------------
>
> Key: GOBBLIN-1397
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1397
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Vikram Bohra
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Related to https://issues.apache.org/jira/browse/GOBBLIN-1391
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
