Jay Sen created GOBBLIN-1401:
--------------------------------
Summary: [bug in disguise] job status not marked accurately
Key: GOBBLIN-1401
URL: https://issues.apache.org/jira/browse/GOBBLIN-1401
Project: Apache Gobblin
Issue Type: Bug
Components: gobblin-core
Affects Versions: 0.15.0
Reporter: Jay Sen
Assignee: Abhishek Tiwari
Fix For: 0.16.0
The JOB_SUCCEEDED timer event actually calls job failure notification to all
listeners.
{code: java}
notifyListeners(this.jobContext, jobListener,
TimingEvent.LauncherTimings.JOB_SUCCEEDED, new JobListenerAction() {
@Override
public void apply(JobListener jobListener, JobContext
jobContext)
throws Exception {
jobListener.onJobFailure(jobContext);
}
});
{code}
Following 2 listeners are registered at this point to be called.
1) JobExecutionEventSubmitterListener
2) JobListenerToJobStateBridge
Luckily, Both does not implement/override `onJobFailure` method so it just logs
and come back.
Actually JOB_COMPLETE takes care of both marking it SUCCESSFUL and then
COMMITTED. so we either dont need this explicit JOB_SUCCEEDED event notifier or
need to have explicit marking the job SUCCESSFUL and remove it from the
JOB_COMPLETE event listener handler.
{code}
// TODO Remove next line once the JobLauncher starts sending notifications for
success
_jobState.switchToSuccessful();
_jobState.switchToCommitted();
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
