ZihanLi58 commented on a change in pull request #3234:
URL: https://github.com/apache/gobblin/pull/3234#discussion_r585850403



##########
File path: 
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/HiveRegister.java
##########
@@ -322,7 +322,7 @@ public void addOrAlterPartition(HiveTable table, 
HivePartition partition)
     }
   }
 
-  protected boolean needToUpdateTable(HiveTable existingTable, HiveTable 
newTable) {
+  public boolean needToUpdateTable(HiveTable existingTable, HiveTable 
newTable) {

Review comment:
       I move it under gobblin-hive-registration module but a new package 
writer for better management. So it still needs to be changed to public. Let me 
know if you have any concerns




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to