[
https://issues.apache.org/jira/browse/GOBBLIN-1377?focusedWorklogId=562686&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-562686
]
ASF GitHub Bot logged work on GOBBLIN-1377:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Mar/21 23:06
Start Date: 08/Mar/21 23:06
Worklog Time Spent: 10m
Work Description: Will-Lo commented on a change in pull request #3158:
URL: https://github.com/apache/gobblin/pull/3158#discussion_r589814984
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/hive/HiveDataset.java
##########
@@ -130,7 +130,9 @@ public HiveDataset(FileSystem fs, HiveMetastoreClientPool
clientPool, Table tabl
this.tableIdentifier = this.table.getDbName() + "." +
this.table.getTableName();
Path tableLocation = this.table.getPath();
if (!(this.properties.isEmpty())) {
Review comment:
Yes you're right I'll check specifically for the added flag in the state
instead, not sure why it was implemented like this @autumnust if you have more
context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 562686)
Time Spent: 1h 20m (was: 1h 10m)
> Add class to create directory shards on cloud environments for hive distcp
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-1377
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1377
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: William Lo
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
