ZihanLi58 commented on a change in pull request #3240:
URL: https://github.com/apache/gobblin/pull/3240#discussion_r589862780
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/workunit/packer/KafkaTopicGroupingWorkUnitPacker.java
##########
@@ -187,6 +188,10 @@ public KafkaTopicGroupingWorkUnitPacker(AbstractSource<?,
?> source, SourceState
containerCapacity =
getContainerCapacityForTopic(capacitiesByTopic.get(topic),
this.containerCapacityComputationStrategy);
log.info("Container capacity for topic {}: {}", topic,
containerCapacity);
}
+ //Add CONTAINER_CAPACITY into each workunit. Useful when
KafkaIngestionHealthCheck is enabled.
Review comment:
Do you want call addContainerCapacityToWorkunits() here?
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaIngestionHealthCheck.java
##########
@@ -65,7 +65,7 @@ public KafkaIngestionHealthCheck(Config config,
KafkaExtractorStatsTracker stats
this.slidingWindowSize = ConfigUtils.getInt(config,
KAFKA_INGESTION_HEALTH_CHECK_SLIDING_WINDOW_SIZE_KEY,
DEFAULT_KAFKA_INGESTION_HEALTH_CHECK_SLIDING_WINDOW_SIZE);
this.ingestionLatencyThresholdMinutes = ConfigUtils.getLong(config,
KAFKA_INGESTION_HEALTH_CHECK_LATENCY_THRESHOLD_MINUTES_KEY,
DEFAULT_KAFKA_INGESTION_HEALTH_CHECK_LATENCY_THRESHOLD_MINUTES);
this.consumptionRateDropOffFraction = ConfigUtils.getDouble(config,
KAFKA_INGESTION_HEALTH_CHECK_CONSUMPTION_RATE_DROPOFF_FRACTION_KEY,
DEFAULT_KAFKA_INGESTION_HEALTH_CHECK_CONSUMPTION_RATE_DROPOFF_FRACTION);
- this.expectedConsumptionRate = ConfigUtils.getDouble(config,
KAFKA_INGESTION_HEALTH_CHECK_EXPECTED_CONSUMPTION_RATE_MBPS_KEY,
DEFAULT_KAFKA_INGESTION_HEALTH_CHECK_EXPECTED_CONSUMPTION_RATE_MBPS);
Review comment:
Does KAFKA_INGESTION_HEALTH_CHECK_EXPECTED_CONSUMPTION_RATE_MBPS_KEY be
referenced anywhere else? If not, should we delete it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
