[
https://issues.apache.org/jira/browse/GOBBLIN-1406?focusedWorklogId=562766&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-562766
]
ASF GitHub Bot logged work on GOBBLIN-1406:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Mar/21 01:10
Start Date: 09/Mar/21 01:10
Worklog Time Spent: 10m
Work Description: sv2000 commented on a change in pull request #3240:
URL: https://github.com/apache/gobblin/pull/3240#discussion_r589865087
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaIngestionHealthCheck.java
##########
@@ -65,7 +65,7 @@ public KafkaIngestionHealthCheck(Config config,
KafkaExtractorStatsTracker stats
this.slidingWindowSize = ConfigUtils.getInt(config,
KAFKA_INGESTION_HEALTH_CHECK_SLIDING_WINDOW_SIZE_KEY,
DEFAULT_KAFKA_INGESTION_HEALTH_CHECK_SLIDING_WINDOW_SIZE);
this.ingestionLatencyThresholdMinutes = ConfigUtils.getLong(config,
KAFKA_INGESTION_HEALTH_CHECK_LATENCY_THRESHOLD_MINUTES_KEY,
DEFAULT_KAFKA_INGESTION_HEALTH_CHECK_LATENCY_THRESHOLD_MINUTES);
this.consumptionRateDropOffFraction = ConfigUtils.getDouble(config,
KAFKA_INGESTION_HEALTH_CHECK_CONSUMPTION_RATE_DROPOFF_FRACTION_KEY,
DEFAULT_KAFKA_INGESTION_HEALTH_CHECK_CONSUMPTION_RATE_DROPOFF_FRACTION);
- this.expectedConsumptionRate = ConfigUtils.getDouble(config,
KAFKA_INGESTION_HEALTH_CHECK_EXPECTED_CONSUMPTION_RATE_MBPS_KEY,
DEFAULT_KAFKA_INGESTION_HEALTH_CHECK_EXPECTED_CONSUMPTION_RATE_MBPS);
Review comment:
Thanks! Good catch. Fixed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 562766)
Time Spent: 50m (was: 40m)
> Make KafkaIngestionHealth check use auto-tuned consumer capacity config
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-1406
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1406
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-kafka
> Affects Versions: 0.16.0
> Reporter: Sudarshan Vasudevan
> Assignee: Shirshanka Das
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> This task allows the KafkaIngestionHealthCheck to access the auto-configured
> configuration for container capacity.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
