Will-Lo commented on a change in pull request #3242:
URL: https://github.com/apache/gobblin/pull/3242#discussion_r592015118
##########
File path:
gobblin-metastore/src/test/java/org/apache/gobblin/metastore/testing/TestMetastoreDatabaseServer.java
##########
@@ -152,10 +152,12 @@ private MySqlJdbcUrl getBaseJdbcUrl() throws
URISyntaxException {
}
private MySqlJdbcUrl getInformationSchemaJdbcUrl() throws URISyntaxException
{
+ // embedded mysql has an empty password by default
+ String password = this.embeddedMysqlEnabled ? "" : ROOT_PASSWORD;
Review comment:
on CI it doesn't use embedded mysql, it talks to a MYSQL instance that's
configured in the test environment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
