[
https://issues.apache.org/jira/browse/GOBBLIN-1409?focusedWorklogId=565461&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-565461
]
ASF GitHub Bot logged work on GOBBLIN-1409:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Mar/21 19:14
Start Date: 12/Mar/21 19:14
Worklog Time Spent: 10m
Work Description: codecov-io commented on pull request #3244:
URL: https://github.com/apache/gobblin/pull/3244#issuecomment-797695770
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3244?src=pr&el=h1)
Report
> Merging
[#3244](https://codecov.io/gh/apache/gobblin/pull/3244?src=pr&el=desc)
(9f53f71) into
[master](https://codecov.io/gh/apache/gobblin/commit/1cbe3d0aacf47edb78bf50986d70047e49f72798?el=desc)
(1cbe3d0) will **decrease** coverage by `37.37%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/gobblin/pull/3244?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3244 +/- ##
============================================
- Coverage 46.40% 9.03% -37.38%
+ Complexity 9940 1737 -8203
============================================
Files 2030 2030
Lines 78783 78786 +3
Branches 8765 8766 +1
============================================
- Hits 36561 7117 -29444
- Misses 38815 70973 +32158
+ Partials 3407 696 -2711
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3244?src=pr&el=tree) |
Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...che/gobblin/kafka/client/Kafka1ConsumerClient.java](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9rYWZrYS9jbGllbnQvS2Fma2ExQ29uc3VtZXJDbGllbnQuamF2YQ==)
| `0.00% <0.00%> (-23.72%)` | `0.00 <0.00> (-6.00)` | |
|
[...c/main/java/org/apache/gobblin/util/FileUtils.java](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRmlsZVV0aWxzLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
|
[...n/java/org/apache/gobblin/fork/CopyableSchema.java](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZvcmsvQ29weWFibGVTY2hlbWEuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
|
[...java/org/apache/gobblin/stream/ControlMessage.java](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc3RyZWFtL0NvbnRyb2xNZXNzYWdlLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...va/org/apache/gobblin/dataset/DatasetResolver.java](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YXNldC9EYXRhc2V0UmVzb2x2ZXIuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
|
[...va/org/apache/gobblin/converter/EmptyIterable.java](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9FbXB0eUl0ZXJhYmxlLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...org/apache/gobblin/ack/BasicAckableForTesting.java](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYWNrL0Jhc2ljQWNrYWJsZUZvclRlc3RpbmcuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
|
[...n/java/org/apache/gobblin/salesforce/SfConfig.java](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2ZDb25maWcuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[.../org/apache/gobblin/yarn/HelixMessageSubTypes.java](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vSGVsaXhNZXNzYWdlU3ViVHlwZXMuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...va/org/apache/gobblin/cluster/SingleHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2luZ2xlSGVsaXhUYXNrLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [1074
more](https://codecov.io/gh/apache/gobblin/pull/3244/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3244?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3244?src=pr&el=footer).
Last update
[1cbe3d0...9f53f71](https://codecov.io/gh/apache/gobblin/pull/3244?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 565461)
Time Spent: 1h 20m (was: 1h 10m)
> Expose Kafka timestamp via Kafka1ConsumerRecord
> -----------------------------------------------
>
> Key: GOBBLIN-1409
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1409
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-kafka
> Reporter: Dan Andreescu
> Assignee: Shirshanka Das
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> When consuming from Kafka, we need the kafka timestamp. We weren't sure if
> there was another way to expose this, but figured it's a general enough need
> that it should be implemented. And it didn't affect performance as far as we
> could see.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
