sv2000 commented on a change in pull request #3158:
URL: https://github.com/apache/gobblin/pull/3158#discussion_r596321614
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/hive/HiveDataset.java
##########
@@ -86,14 +86,15 @@
public static final String DATASET_NAME_PATTERN_KEY =
"hive.datasetNamePattern";
public static final String DATABASE = "Database";
public static final String TABLE = "Table";
- public static final String DATASET_STAGING_PATH = "dataset.staging.path";
public static final String DATABASE_TOKEN = "$DB";
public static final String TABLE_TOKEN = "$TABLE";
public static final String LOGICAL_DB_TOKEN = "$LOGICAL_DB";
public static final String LOGICAL_TABLE_TOKEN = "$LOGICAL_TABLE";
+ public String datasetPath;
Review comment:
Should this be private?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
