[
https://issues.apache.org/jira/browse/GOBBLIN-1396?focusedWorklogId=568689&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-568689
]
ASF GitHub Bot logged work on GOBBLIN-1396:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/21 00:07
Start Date: 19/Mar/21 00:07
Worklog Time Spent: 10m
Work Description: codecov-io edited a comment on pull request #3234:
URL: https://github.com/apache/gobblin/pull/3234#issuecomment-799844377
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3234?src=pr&el=h1)
Report
> Merging
[#3234](https://codecov.io/gh/apache/gobblin/pull/3234?src=pr&el=desc)
(5da7dad) into
[master](https://codecov.io/gh/apache/gobblin/commit/520eca8938231494bddd5c477e07ec71c7da653f?el=desc)
(520eca8) will **decrease** coverage by `3.46%`.
> The diff coverage is `4.19%`.
[](https://codecov.io/gh/apache/gobblin/pull/3234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3234 +/- ##
============================================
- Coverage 46.38% 42.91% -3.47%
+ Complexity 9936 9244 -692
============================================
Files 2030 2034 +4
Lines 78743 79034 +291
Branches 8759 8807 +48
============================================
- Hits 36521 33914 -2607
- Misses 38820 41903 +3083
+ Partials 3402 3217 -185
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3234?src=pr&el=tree) |
Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...ain/java/org/apache/gobblin/hive/HiveRegister.java](https://codecov.io/gh/apache/gobblin/pull/3234/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL0hpdmVSZWdpc3Rlci5qYXZh)
| `14.10% <ø> (ø)` | `2.00 <0.00> (ø)` | |
|
[...lin/hive/metastore/HiveMetaStoreBasedRegister.java](https://codecov.io/gh/apache/gobblin/pull/3234/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL21ldGFzdG9yZS9IaXZlTWV0YVN0b3JlQmFzZWRSZWdpc3Rlci5qYXZh)
| `10.24% <0.00%> (+0.02%)` | `5.00 <0.00> (ø)` | |
|
[...apache/gobblin/hive/writer/HiveMetadataWriter.java](https://codecov.io/gh/apache/gobblin/pull/3234/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL3dyaXRlci9IaXZlTWV0YWRhdGFXcml0ZXIuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
|
[...pache/gobblin/iceberg/writer/GobblinMCEWriter.java](https://codecov.io/gh/apache/gobblin/pull/3234/diff?src=pr&el=tree#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvd3JpdGVyL0dvYmJsaW5NQ0VXcml0ZXIuamF2YQ==)
| `70.73% <66.66%> (ø)` | `21.00 <0.00> (ø)` | |
|
[...n/java/org/apache/gobblin/writer/FsDataWriter.java](https://codecov.io/gh/apache/gobblin/pull/3234/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9Gc0RhdGFXcml0ZXIuamF2YQ==)
| `71.05% <100.00%> (-5.27%)` | `14.00 <0.00> (-1.00)` | |
|
[.../gobblin/iceberg/writer/IcebergMetadataWriter.java](https://codecov.io/gh/apache/gobblin/pull/3234/diff?src=pr&el=tree#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvd3JpdGVyL0ljZWJlcmdNZXRhZGF0YVdyaXRlci5qYXZh)
| `67.58% <100.00%> (ø)` | `51.00 <0.00> (ø)` | |
|
[.../org/apache/gobblin/util/filters/HiddenFilter.java](https://codecov.io/gh/apache/gobblin/pull/3234/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsdGVycy9IaWRkZW5GaWx0ZXIuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
|
[...g/apache/gobblin/cluster/HelixMessageSubTypes.java](https://codecov.io/gh/apache/gobblin/pull/3234/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhNZXNzYWdlU3ViVHlwZXMuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...gobblin/runtime/mapreduce/GobblinOutputFormat.java](https://codecov.io/gh/apache/gobblin/pull/3234/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0dvYmJsaW5PdXRwdXRGb3JtYXQuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
|
[...obblin/compaction/source/CompactionFailedTask.java](https://codecov.io/gh/apache/gobblin/pull/3234/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc291cmNlL0NvbXBhY3Rpb25GYWlsZWRUYXNrLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [172
more](https://codecov.io/gh/apache/gobblin/pull/3234/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3234?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3234?src=pr&el=footer).
Last update
[520eca8...5da7dad](https://codecov.io/gh/apache/gobblin/pull/3234?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 568689)
Time Spent: 2.5h (was: 2h 20m)
> Enable HiveWriter to consume gmce and register into hive MetadataStore
> ----------------------------------------------------------------------
>
> Key: GOBBLIN-1396
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1396
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Add hiveWriter as one subtype of metadataWriter, so that it can consume gmce
> and register into hive metaStore. The writer should avoid trying to register
> the same HiveSpec several times also it should be able to handle the schema
> evolution.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
