[
https://issues.apache.org/jira/browse/GOBBLIN-1416?focusedWorklogId=569188&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-569188
]
ASF GitHub Bot logged work on GOBBLIN-1416:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/21 23:46
Start Date: 19/Mar/21 23:46
Worklog Time Spent: 10m
Work Description: autumnust commented on a change in pull request #3250:
URL: https://github.com/apache/gobblin/pull/3250#discussion_r598024598
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/GobblinMultiTaskAttempt.java
##########
@@ -157,6 +161,11 @@ public void run()
Pair<List<Task>, Boolean> executionResult = runWorkUnits(countDownLatch);
this.tasks = executionResult.getFirst();
+ if (this.tasks.isEmpty() && this.stopped.get()) {
Review comment:
Let me know if this understanding is correct: whenever these two
conditions hold at the same time, it indicates that the cancel happens before
the task is materialized and executed in the executor. ( since the regular
cancel will result in tasks being non empty). Can you add a comment if this is
the case, just to distinguish between the regular cancel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 569188)
Time Spent: 50m (was: 40m)
> Fix a race condition caused by Helix task cancellation being invoked before
> Gobblin task creation
> -------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1416
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1416
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Affects Versions: 0.16.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Invocation of Gobblin Helix task cancellation before underlying Gobblin tasks
> have been created or submitted to the task executor results in
> GobblinHelixTask#cancel() returning successfully, but without preventing
> future submission of Gobblin tasks to the executor.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
