[
https://issues.apache.org/jira/browse/GOBBLIN-1418?focusedWorklogId=574484&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-574484
]
ASF GitHub Bot logged work on GOBBLIN-1418:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Mar/21 01:12
Start Date: 31/Mar/21 01:12
Worklog Time Spent: 10m
Work Description: jack-moseley commented on a change in pull request
#3254:
URL: https://github.com/apache/gobblin/pull/3254#discussion_r604528738
##########
File path:
gobblin-api/src/main/java/org/apache/gobblin/password/EncryptedPasswordAuthenticator.java
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.password;
+
+import java.net.Authenticator;
+import java.net.PasswordAuthentication;
+import java.util.Properties;
+
+import com.google.common.base.Preconditions;
+
+
+/**
+ * {@link Authenticator} that uses a username and password from the provided
{@link Properties} to authenticate, and
+ * also decrypts the password using {@link PasswordManager}
+ */
+public class EncryptedPasswordAuthenticator extends Authenticator {
Review comment:
Is there anything worth testing here? The only actual logic is calling
PasswordManager, and based on PasswordManagerTest, it seems like we can't even
enable tests that use that due to flakiness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 574484)
Time Spent: 50m (was: 40m)
> Add config to make it possible to specify a default Authenticator for a job
> ---------------------------------------------------------------------------
>
> Key: GOBBLIN-1418
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1418
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
