ZihanLi58 commented on a change in pull request #3255:
URL: https://github.com/apache/gobblin/pull/3255#discussion_r613437586
##########
File path:
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/verify/CompactionThresholdVerifier.java
##########
@@ -60,7 +62,8 @@ public CompactionThresholdVerifier(State state) {
* dataset. To avoid scalability issue, we choose a stateless approach where
each dataset tracks
* record count by themselves and persist it in the file system)
*
- * @return true iff the difference exceeds the threshold or this is the
first time compaction
+ * @return true if the difference exceeds the threshold or this is the first
time compaction or
Review comment:
So the logic of verifier is if any of the verifier fail the dataset, the
compaction will not run. In this case, if gmce verifier say it needs to re
compact but threshold verifier say it does not need to be compacted, then the
dataset will be skipped. That's the reason I embedded the logic here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
