[
https://issues.apache.org/jira/browse/GOBBLIN-1429?focusedWorklogId=584593&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584593
]
ASF GitHub Bot logged work on GOBBLIN-1429:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/21 06:34
Start Date: 17/Apr/21 06:34
Worklog Time Spent: 10m
Work Description: treff7es commented on a change in pull request #3264:
URL: https://github.com/apache/gobblin/pull/3264#discussion_r615215815
##########
File path: gobblin-utility/src/main/java/org/apache/gobblin/util/LdapUtils.java
##########
@@ -87,7 +94,11 @@ private DirContext getDirContext(String username, String
password) throws Naming
env.put(Context.SECURITY_PRINCIPAL, username);
env.put(Context.SECURITY_CREDENTIALS, password);
- env.put("java.naming.ldap.factory.socket",
TrustManagerSocketFactory.class.getCanonicalName());
+ if (_ldapUseSecureTrustManager) {
+ env.put("java.naming.ldap.factory.socket",
TrustManagerSocketFactory.class.getCanonicalName());
Review comment:
I think you mixed up the branches here as this one should be the secure
one and the other one the non-secure one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 584593)
Time Spent: 20m (was: 10m)
> Add secure TrustManager for LDAP Utils
> --------------------------------------
>
> Key: GOBBLIN-1429
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1429
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Abhishek Tiwari
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
