abti commented on a change in pull request #3264:
URL: https://github.com/apache/gobblin/pull/3264#discussion_r615216297
##########
File path: gobblin-utility/src/main/java/org/apache/gobblin/util/LdapUtils.java
##########
@@ -87,7 +94,11 @@ private DirContext getDirContext(String username, String
password) throws Naming
env.put(Context.SECURITY_PRINCIPAL, username);
env.put(Context.SECURITY_CREDENTIALS, password);
- env.put("java.naming.ldap.factory.socket",
TrustManagerSocketFactory.class.getCanonicalName());
+ if (_ldapUseSecureTrustManager) {
+ env.put("java.naming.ldap.factory.socket",
TrustManagerSocketFactory.class.getCanonicalName());
Review comment:
yes, good catch. fixing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
