[
https://issues.apache.org/jira/browse/GOBBLIN-1432?focusedWorklogId=587550&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587550
]
ASF GitHub Bot logged work on GOBBLIN-1432:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Apr/21 22:13
Start Date: 22/Apr/21 22:13
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on pull request #3270:
URL: https://github.com/apache/gobblin/pull/3270#issuecomment-825217371
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3270?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3270](https://codecov.io/gh/apache/gobblin/pull/3270?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(e72a3e3) into
[master](https://codecov.io/gh/apache/gobblin/commit/f11d68ff07bb64f29024cb09ec2b7bf217bc0ba5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(f11d68f) will **increase** coverage by `0.02%`.
> The diff coverage is `11.11%`.
> :exclamation: Current head e72a3e3 differs from pull request most recent
head b05dc06. Consider uploading reports for the commit b05dc06 to get more
accurate results
[](https://codecov.io/gh/apache/gobblin/pull/3270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3270 +/- ##
============================================
+ Coverage 46.46% 46.48% +0.02%
- Complexity 9993 10002 +9
============================================
Files 2036 2037 +1
Lines 79180 79208 +28
Branches 8831 8833 +2
============================================
+ Hits 36794 36823 +29
Misses 38960 38960
+ Partials 3426 3425 -1
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3270?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[.../main/java/org/apache/gobblin/KafkaCommonUtil.java](https://codecov.io/gh/apache/gobblin/pull/3270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL0thZmthQ29tbW9uVXRpbC5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
|
[...che/gobblin/metrics/kafka/KafkaProducerPusher.java](https://codecov.io/gh/apache/gobblin/pull/3270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMDgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9rYWZrYS9LYWZrYVByb2R1Y2VyUHVzaGVyLmphdmE=)
| `75.51% <37.50%> (+75.51%)` | `12.00 <1.00> (+12.00)` | |
|
[...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh)
| `58.06% <0.00%> (-4.31%)` | `6.00% <0.00%> (ø%)` | |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/gobblin/pull/3270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `32.23% <0.00%> (-2.48%)` | `12.00% <0.00%> (-1.00%)` | |
|
[...main/java/org/apache/gobblin/yarn/YarnService.java](https://codecov.io/gh/apache/gobblin/pull/3270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFyblNlcnZpY2UuamF2YQ==)
| `14.36% <0.00%> (-0.79%)` | `4.00% <0.00%> (-1.00%)` | |
|
[...blin/service/modules/orchestration/DagManager.java](https://codecov.io/gh/apache/gobblin/pull/3270/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXIuamF2YQ==)
| `70.98% <0.00%> (+0.09%)` | `13.00% <0.00%> (ø%)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3270?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3270?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[f11d68f...b05dc06](https://codecov.io/gh/apache/gobblin/pull/3270?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 587550)
Time Spent: 20m (was: 10m)
> JVM hangs on flushing events after OOM
> --------------------------------------
>
> Key: GOBBLIN-1432
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1432
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-kafka, gobblin-metrics
> Reporter: Hanghang Liu
> Assignee: Shirshanka Das
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> A hang was observed for ingestion flows after an OOM.
> This appears to be due to the kafka pusher flush() call not returning.
> Hanging stack.
> {code:java}
> at
> org.apache.kafka.clients.producer.internals.FutureRecordMetadata.get(FutureRecordMetadata.java:29)
> at
> org.apache.gobblin.metrics.kafka.KafkaProducerPusher.flush(KafkaProducerPusher.java:125)
> at
> org.apache.gobblin.metrics.kafka.KafkaProducerPusher.close(KafkaProducerPusher.java:137)
> at com.google.common.io.Closer.close(Closer.java:214) at
> org.apache.gobblin.metrics.reporter.ConfiguredScheduledReporter.close(ConfiguredScheduledReporter.java:245)
> at com.google.common.io.Closer.close(Closer.java:214) at
> org.apache.gobblin.metrics.MetricContext.close(MetricContext.java:553)
> at
> org.apache.gobblin.metrics.RootMetricContext$1.run(RootMetricContext.java:194){code}
>
> Shutdown hook call
> {code:java}
> "DestroyJavaVM" #308 prio=5 os_prio=0 tid=0x00007fb55c01a800 nid=0x5d51 in
> Object.wait() [0x00007fb563f5b000] java.lang.Thread.State: WAITING (on
> object monitor) at java.lang.Object.wait(Native Method) -
> waiting on <0x00000000e036cf30> (a
> org.apache.gobblin.metrics.RootMetricContext$1) at
> java.lang.Thread.join(Thread.java:1252) - locked <0x00000000e036cf30>
> (a org.apache.gobblin.metrics.RootMetricContext$1) at
> java.lang.Thread.join(Thread.java:1326) at
> java.lang.ApplicationShutdownHooks.runHooks(ApplicationShutdownHooks.java:107)
> at
> java.lang.ApplicationShutdownHooks$1.run(ApplicationShutdownHooks.java:46){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
