[
https://issues.apache.org/jira/browse/GOBBLIN-1438?focusedWorklogId=591741&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-591741
]
ASF GitHub Bot logged work on GOBBLIN-1438:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Apr/21 22:19
Start Date: 30/Apr/21 22:19
Worklog Time Spent: 10m
Work Description: jack-moseley opened a new pull request #3272:
URL: https://github.com/apache/gobblin/pull/3272
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1438
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
This PR changes failed dags to only be loaded if resume is called (and only
the dag that was resumed is loaded) to avoid keeping all failed dags in memory
at all times, since this can cause memory issues.
Changes for this:
- In `DagManager`, keep a list of failed dagIds instead of a map of all
failed dags. This list is still needed to know which dags to clean up, and also
allows us to avoid calling the dag store for dags that aren't there.
- Add an API in `DagStateStore` to load only one dag, because previously the
only option was to load all dags at once, which would still cause memory issues.
- Add an API in `DagStateStore` to get all dag IDs
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Updated unit tests and tested resuming locally
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 591741)
Remaining Estimate: 0h
Time Spent: 10m
> Only load failed dags at time of resume
> ---------------------------------------
>
> Key: GOBBLIN-1438
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1438
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
