arjun4084346 commented on a change in pull request #3268:
URL: https://github.com/apache/gobblin/pull/3268#discussion_r624257475
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/job_catalog/NonObservingFSJobCatalog.java
##########
@@ -105,6 +105,14 @@ public synchronized void remove(URI jobURI) {
remove(jobURI, false);
}
+ /**
+ * Removes a job from job catalog.
+ * If it is a flow delete request from service side, then
alwaysTriggerListeners should be set to true so that a
+ * running job will also be cancelled. If it is a remove request because a
job finishes or has been submitted to helix,
+ * then alwaysTriggerListeners should be set to false so that job
cancellation is not triggered.
+ * @param jobURI job uri
+ * @param alwaysTriggerListeners if it is true, a running job will be
cancelled.
Review comment:
passing EventBus object from JobConfigurationManager to JobMonitor and
making JobMonitor directly posting a cancel event
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
