Will-Lo commented on a change in pull request #3273:
URL: https://github.com/apache/gobblin/pull/3273#discussion_r625429487
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_catalog/FlowCatalog.java
##########
@@ -366,11 +376,17 @@ public Spec getSpecWrapper(URI uri) {
return responseMap;
}
- public static boolean isCompileSuccessful(Map<String, AddSpecResponse>
responseMap) {
- AddSpecResponse<String> addSpecResponse = responseMap.getOrDefault(
- ServiceConfigKeys.GOBBLIN_SERVICE_JOB_SCHEDULER_LISTENER_CLASS, new
AddSpecResponse<>(""));
-
- return isCompileSuccessful(addSpecResponse.getValue());
+ public boolean isCompileSuccessful(Map<String, AddSpecResponse> responseMap)
{
+ for (SpecCatalogListener listener: this.listeners.getListeners()) {
+ String listenerClass = listener.getClass().getCanonicalName();
+ AddSpecResponse<String> addSpecResponse =
Review comment:
I needed this originally for testing purposes and potentially for
extensibility but realized that I can mock the name of the expected listener
instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
