arjun4084346 commented on pull request #3274: URL: https://github.com/apache/gobblin/pull/3274#issuecomment-833666076
cancel used to happen by putting a job spec in cancel job catalog so that listeners of the job catalog can initiate the cancellation. but @aplex pointed out https://github.com/apache/gobblin/pull/3268#discussion_r621514282 that this is not a good architecture and then we decided to remove the 'cancellation via triggering job catalog' and made the KafkaJobMonitor initiate the cancellation. This architecture change made some code dead. It was suggested that this dead code should be removed https://github.com/apache/gobblin/pull/3268#pullrequestreview-650608412 so I removed it. Note that the dead code was not already dead, it was due to this PR that made it dead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
