[
https://issues.apache.org/jira/browse/GOBBLIN-1441?focusedWorklogId=593120&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-593120
]
ASF GitHub Bot logged work on GOBBLIN-1441:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/May/21 03:06
Start Date: 07/May/21 03:06
Worklog Time Spent: 10m
Work Description: codecov-commenter edited a comment on pull request
#3276:
URL: https://github.com/apache/gobblin/pull/3276#issuecomment-833978480
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3276?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3276](https://codecov.io/gh/apache/gobblin/pull/3276?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(f94ee03) into
[master](https://codecov.io/gh/apache/gobblin/commit/f72523c3ed8b2b05a77accb96d6a845324d90e69?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(f72523c) will **decrease** coverage by `37.52%`.
> The diff coverage is `3.57%`.
[](https://codecov.io/gh/apache/gobblin/pull/3276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3276 +/- ##
============================================
- Coverage 46.52% 9.00% -37.53%
+ Complexity 10014 1742 -8272
============================================
Files 2037 2037
Lines 79229 79270 +41
Branches 8836 8838 +2
============================================
- Hits 36861 7135 -29726
- Misses 38949 71433 +32484
+ Partials 3419 702 -2717
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...a/org/apache/gobblin/runtime/api/SpecExecutor.java](https://codecov.io/gh/apache/gobblin/pull/3276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9hcGkvU3BlY0V4ZWN1dG9yLmphdmE=)
| `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
|
[.../apache/gobblin/cluster/GobblinClusterManager.java](https://codecov.io/gh/apache/gobblin/pull/3276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJNYW5hZ2VyLmphdmE=)
| `42.79% <ø> (-9.53%)` | `19.00 <0.00> (-4.00)` | |
|
[...org/apache/gobblin/runtime/api/FsSpecConsumer.java](https://codecov.io/gh/apache/gobblin/pull/3276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0ZzU3BlY0NvbnN1bWVyLmphdmE=)
| `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-6.00)` | |
|
[...org/apache/gobblin/runtime/api/FsSpecProducer.java](https://codecov.io/gh/apache/gobblin/pull/3276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0ZzU3BlY1Byb2R1Y2VyLmphdmE=)
| `0.00% <0.00%> (-73.59%)` | `0.00 <0.00> (-9.00)` | |
|
[...untime/job\_monitor/AvroJobSpecKafkaJobMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvQXZyb0pvYlNwZWNLYWZrYUpvYk1vbml0b3IuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...bblin/runtime/job\_monitor/KafkaAvroJobMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FBdnJvSm9iTW9uaXRvci5qYXZh)
| `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
|
[...e/gobblin/runtime/job\_monitor/KafkaJobMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FKb2JNb25pdG9yLmphdmE=)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...n/runtime/job\_monitor/SLAEventKafkaJobMonitor.java](https://codecov.io/gh/apache/gobblin/pull/3276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvU0xBRXZlbnRLYWZrYUpvYk1vbml0b3IuamF2YQ==)
| `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
|
[...n/java/org/apache/gobblin/runtime/api/JobSpec.java](https://codecov.io/gh/apache/gobblin/pull/3276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYlNwZWMuamF2YQ==)
| `38.41% <100.00%> (-41.73%)` | `10.00 <0.00> (-7.00)` | |
|
[...c/main/java/org/apache/gobblin/util/FileUtils.java](https://codecov.io/gh/apache/gobblin/pull/3276/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRmlsZVV0aWxzLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [1089
more](https://codecov.io/gh/apache/gobblin/pull/3276/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3276?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3276?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[f72523c...f94ee03](https://codecov.io/gh/apache/gobblin/pull/3276?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 593120)
Time Spent: 0.5h (was: 20m)
> distinguish delete and cancel flows in KafkaJobMonitor
> ------------------------------------------------------
>
> Key: GOBBLIN-1441
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1441
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> * make KafkaJobMonitor s parseJobSpec() method return the entire JobSpec, so
> that the caller method processMessage() can distinguish between a DELETE FLOW
> and CANCEL JOB requests and take appropriate actions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
