[
https://issues.apache.org/jira/browse/GOBBLIN-1440?focusedWorklogId=594646&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-594646
]
ASF GitHub Bot logged work on GOBBLIN-1440:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/21 17:20
Start Date: 11/May/21 17:20
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#3277:
URL: https://github.com/apache/gobblin/pull/3277#discussion_r630380253
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobScheduler.java
##########
@@ -370,9 +372,15 @@ public void
handleDeleteJobConfigArrival(DeleteJobConfigArrivalEvent deleteJobAr
}
@Subscribe
- public void handleCancelJobConfigArrival(CancelJobConfigArrivalEvent
cancelJobArrival)
+ public void handleJobConfigArrival(JobConfigArrivalEvent jobArrival)
throws InterruptedException {
- String jobUri = cancelJobArrival.getJoburi();
+ String jobUri = jobArrival.uri.toString();
+
+ if (jobArrival.verb != SpecExecutor.Verb.CANCEL) {
+ LOGGER.info("Received {} event for job uri {}. Taking no action.",
jobArrival.verb, jobUri);
Review comment:
For now, this method `public void
handleJobConfigArrival(JobConfigArrivalEvent jobArrival)` should be only
triggered for cancel jobs, because add/update/delete uses their own unique
`XXXJobConfigArrivalEvent`
I added this log, so that in future, if someone adds a new verb, or moves
add/update/delete to use the generic `JobConfigArrivalEvent` he should get a
log that for now, only CANCEL are being handled.
It could have been a `warn` message actually.
Because only cancel requests are calling this method, it should not spam the
logs. In fact, it should not come here at all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 594646)
Remaining Estimate: 0h
Time Spent: 10m
> move 'cancel trigger code' from job catalog to job monitor
> -----------------------------------------------------------
>
> Key: GOBBLIN-1440
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1440
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently Add/update/delete of flow specs and cancellation of a job execution
> happen via putting/deleting these specs in job catalog. Listeners of Spec
> Catalog take appropriate actions. While for add/update/delete this makes
> sense to modify job catalog, it makes little sense for job execution
> cancellation request to update job catalog in order to trigger the
> cancellation because job and execution are two different entities.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
