[
https://issues.apache.org/jira/browse/GOBBLIN-1444?focusedWorklogId=598739&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-598739
]
ASF GitHub Bot logged work on GOBBLIN-1444:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/May/21 18:05
Start Date: 18/May/21 18:05
Worklog Time Spent: 10m
Work Description: aplex commented on a change in pull request #3281:
URL: https://github.com/apache/gobblin/pull/3281#discussion_r634630227
##########
File path:
gobblin-api/src/main/java/org/apache/gobblin/util/ClassAliasResolver.java
##########
@@ -100,15 +101,17 @@ public String resolve(final String possibleAlias) {
* and is also a subclass of {@link #subtypeOf}, if it fails it returns a
class object for name
* <code>aliasOrClassName</code>.
*/
- public Class<? extends T> resolveClass(final String aliasOrClassName) throws
ClassNotFoundException {
+ public Class<? extends T> resolveClass(final String aliasOrClassName)
+ throws ClassNotFoundException {
Review comment:
I think it's part of Gobblin code style settings, and IntelliJ
automatically reformats the code to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 598739)
Time Spent: 1h 40m (was: 1.5h)
> Use Guice as DI framework in Gobblin service
> --------------------------------------------
>
> Key: GOBBLIN-1444
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1444
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: Alex Prokofiev
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Currently, to initialize Gobblin service, we used a mixture of dependency
> injection, direct class creation and config-based class creation. In this
> change, we unify the service initialization by moving towards using
> dependency injection(DI) with Guice everywhere.
> Using DI will help with (1) unit testing; (2) overriding classes in the
> middle of the dependency with company-specific implementations, and (3) will
> improve code readability, as dependencies between classes become visible from
> the outside and explicit.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
