umustafi commented on a change in pull request #3285:
URL: https://github.com/apache/gobblin/pull/3285#discussion_r635656994
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/main/java/org/apache/gobblin/service/FlowConfigV2Client.java
##########
@@ -214,14 +216,24 @@ public FlowConfig getFlowConfig(FlowId flowId)
String propertyFilter) throws RemoteInvocationException {
LOG.debug("getAllFlowConfigs called");
- FindRequest<FlowConfig> getRequest =
_flowconfigsV2RequestBuilders.findByFilterFlows()
-
.flowGroupParam(flowGroup).flowNameParam(flowName).templateUriParam(templateUri).userToProxyParam(userToProxy)
-
.sourceIdentifierParam(sourceIdentifier).destinationIdentifierParam(destinationIdentifier).scheduleParam(schedule)
-
.isRunImmediatelyParam(isRunImmediately).owningGroupParam(owningGroup).propertyFilterParam(propertyFilter).build();
+ // the following parameters may contain white space
+ try {
+ String decodedSchedule = URLDecoder.decode(schedule,
StandardCharsets.UTF_8.toString());
Review comment:
Double checked the args received by GaaS on EI and the URL encoding of
spaces is actually working (rest.li must be doing it), but the search
functionality itself for schedules appears to be broken. Searching with encoded
spaces on the property filter parameter does work. Cancelling the PR request
then and adding a ticket for the search functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
