ZihanLi58 commented on a change in pull request #3287:
URL: https://github.com/apache/gobblin/pull/3287#discussion_r638256809
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/workunit/packer/KafkaTopicGroupingWorkUnitPacker.java
##########
@@ -338,7 +338,10 @@ private Double getMinWorkUnitSize(WorkUnit workUnit) {
*/
@VisibleForTesting
static double getContainerCapacityForTopic(List<Double> capacities,
ContainerCapacityComputationStrategy strategy) {
- Preconditions.checkArgument(capacities.size() > 0, "Capacities size must
be > 0");
+ //No previous stats for a topic? Return default.
Review comment:
Just curious how did we deal with the new topics previous? Asking
because capacities for new topics should always be null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
