[
https://issues.apache.org/jira/browse/GOBBLIN-1449?focusedWorklogId=601395&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601395
]
ASF GitHub Bot logged work on GOBBLIN-1449:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/May/21 20:43
Start Date: 24/May/21 20:43
Worklog Time Spent: 10m
Work Description: sv2000 commented on a change in pull request #3287:
URL: https://github.com/apache/gobblin/pull/3287#discussion_r638258984
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/workunit/packer/KafkaTopicGroupingWorkUnitPacker.java
##########
@@ -338,7 +338,10 @@ private Double getMinWorkUnitSize(WorkUnit workUnit) {
*/
@VisibleForTesting
static double getContainerCapacityForTopic(List<Double> capacities,
ContainerCapacityComputationStrategy strategy) {
- Preconditions.checkArgument(capacities.size() > 0, "Capacities size must
be > 0");
+ //No previous stats for a topic? Return default.
Review comment:
This was only tested with topics which already had some stats. This
config has not been enabled yet in a large scale production environment at LI
yet. On a recent test, this issue was uncovered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 601395)
Time Spent: 0.5h (was: 20m)
> Correctly parse topic name from topic partition string if topic name has
> hyphens
> --------------------------------------------------------------------------------
>
> Key: GOBBLIN-1449
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1449
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-kafka
> Reporter: Sudarshan Vasudevan
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In KafkaTopicGroupingWorkUnitPacker, the extraction of topic name from topic
> partition string currently does not handle the hyphens in the topic name
> correctly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
