[
https://issues.apache.org/jira/browse/GOBBLIN-1453?focusedWorklogId=603675&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-603675
]
ASF GitHub Bot logged work on GOBBLIN-1453:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/May/21 19:36
Start Date: 28/May/21 19:36
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#3291:
URL: https://github.com/apache/gobblin/pull/3291#discussion_r641777757
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java
##########
@@ -289,10 +288,9 @@ public AddSpecResponse onAddSpec(Spec addedSpec) {
// always try to compile the flow to verify if it is compilable
Dag<JobExecutionPlan> dag =
this.orchestrator.getSpecCompiler().compileFlow(flowSpec);
+ // If dag is null then a compilation error has occurred
Review comment:
Let's updated the javadoc that response is null if compilation fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 603675)
Time Spent: 1h (was: 50m)
> Improve error reporting on flow configs that fail to compile
> ------------------------------------------------------------
>
> Key: GOBBLIN-1453
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1453
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Affects Versions: 0.16.0
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Flow configurations that fail to compile can still be saved in some scenarios.
> Additionally, when they are rejected by the server, there should be a more
> detailed explanation as to why instead of just returning a 400.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
