[
https://issues.apache.org/jira/browse/GOBBLIN-1455?focusedWorklogId=604658&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-604658
]
ASF GitHub Bot logged work on GOBBLIN-1455:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jun/21 17:54
Start Date: 01/Jun/21 17:54
Worklog Time Spent: 10m
Work Description: sv2000 opened a new pull request #3294:
URL: https://github.com/apache/gobblin/pull/3294
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1455
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
We need to upper bound the config gobblin.kafka.minContainersForTopic so as
not to exceed the number of partitions for the topic. When this config value
exceeds the number of partitions, current behavior incorrectly estimates the
work unit size in KafkaTopicGroupingWorkUnitPacker.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Trivial change.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 604658)
Remaining Estimate: 0h
Time Spent: 10m
> Limit gobblin.kafka.minContainersForTopic config to the number of partitions
> of the topic
> -----------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1455
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1455
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-kafka
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Shirshanka Das
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We need to upper bound the config gobblin.kafka.minContainersForTopic so as
> not to exceed the number of partitions for the topic. When this config value
> exceeds the number of partitions, current behavior incorrectly estimates the
> work unit size in KafkaTopicGroupingWorkUnitPacker.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
