[
https://issues.apache.org/jira/browse/GOBBLIN-1398?focusedWorklogId=607544&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607544
]
ASF GitHub Bot logged work on GOBBLIN-1398:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jun/21 23:47
Start Date: 06/Jun/21 23:47
Worklog Time Spent: 10m
Work Description: jhsenjaliya commented on a change in pull request #3236:
URL: https://github.com/apache/gobblin/pull/3236#discussion_r646204591
##########
File path:
gobblin-utility/src/main/java/org/apache/gobblin/util/ConfigUtils.java
##########
@@ -67,12 +70,48 @@
*/
private static final String GOBBLIN_CONFIG_BLACKLIST_KEYS =
"gobblin.config.blacklistKeys";
+ /**
+ * Gobblin sync system specific config
+ */
+ public static final String GOBBLIN_SYNC_SYSTEMS_KEY = "gobblin_sync_systems";
+ public static final String GOBBLIN_SYNC_SYSTEM_CONFIG_FILES_KEY =
"config_files";
+ public static final String GOBBLIN_SYNC_SYSTEM_METASTORE_URI_KEY =
"metastore.uris";
+ public static final String IS_SECURE_KEY = "is_secure";
+ public static final String IS_TOKEN_MGMT_ENABLED_KEY =
"is_token_management_enabled";
+ public static final String CONFIG_FILES_LIST_KEY = "config_files";
+ public static final String HIVE_SYSTEM_KEY = "hive";
+ public static final String HIVE_METASTORE_URI_KEY = "metastore.uris";
+
+
/**
* A suffix that is automatically appended to property keys that are
prefixes of other
* property keys. This is used during Properties -> Config -> Properties
conversion since
* typesafe config does not allow such properties. */
public static final String STRIP_SUFFIX = ".ROOT_VALUE";
+ private static volatile Config instance;
+ public static Config getInstance() {
Review comment:
the empty wont have the config from application.conf and i notice we
keep loading config many times in code. so this method should set the base for
all initial config and provide the singleton instead of loading the config
multiple times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 607544)
Time Spent: 1h 10m (was: 1h)
> Gobblin kerberos token management for multiple remote hive metastores
> ---------------------------------------------------------------------
>
> Key: GOBBLIN-1398
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1398
> Project: Apache Gobblin
> Issue Type: Improvement
> Affects Versions: 0.15.0
> Reporter: Jay Sen
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> GOBBLIN-1308 takes care of ability to connect to remote and secure hive
> metastore, but it still requires the management of hive-site to be provided
> to be container local file.
> When it comes to multiple hive clusters this manual management approach would
> not work, and requires special feature of providing system specific
> hive-site.xml without namespace collision.
>
> This ticket aims to do following things
> 1) define a way to provide remote system configuration ( keep giving flat
> config is more cumbersome )
> 2) based on system config and feature flag, copy config files to container
> local path automatically.
> 3) when creating metastoreClient, pick up the right config for the requested
> system ( identified by the metastore URI )
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
