autumnust commented on a change in pull request #3302:
URL: https://github.com/apache/gobblin/pull/3302#discussion_r647994936
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/FsSpecConsumer.java
##########
@@ -112,8 +113,11 @@ public FsSpecConsumer(@Nullable FileSystem fs, Config
config) {
JobSpec.Builder jobSpecBuilder = new
JobSpec.Builder(avroJobSpec.getUri());
Properties props = new Properties();
props.putAll(avroJobSpec.getProperties());
-
jobSpecBuilder.withJobCatalogURI(avroJobSpec.getUri()).withVersion(avroJobSpec.getVersion())
-
.withDescription(avroJobSpec.getDescription()).withConfigAsProperties(props);
+ jobSpecBuilder.withJobCatalogURI(avroJobSpec.getUri())
+ .withVersion(avroJobSpec.getVersion())
+ .withDescription(avroJobSpec.getDescription())
+ .withConfigAsProperties(props)
Review comment:
This API is quite confusing ... But I get the point why both will be
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
