[
https://issues.apache.org/jira/browse/GOBBLIN-1472?focusedWorklogId=611014&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-611014
]
ASF GitHub Bot logged work on GOBBLIN-1472:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/21 23:34
Start Date: 14/Jun/21 23:34
Worklog Time Spent: 10m
Work Description: Will-Lo commented on a change in pull request #3311:
URL: https://github.com/apache/gobblin/pull/3311#discussion_r651344799
##########
File path:
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/CompactionJobConfigurator.java
##########
@@ -249,6 +250,11 @@ protected boolean configureInputAndOutputPaths(Job job,
FileSystemDataset datase
CompactionPathParser.CompactionParserResult rst = parser.parse(dataset);
this.mrOutputPath = concatPaths(mrOutputBase, rst.getDatasetName(),
rst.getDstSubDir(), rst.getTimeString());
+ if(this.state.contains(ConfigurationKeys.USE_DATASET_LOCAL_WORK_DIR)) {
+ mrOutputBase = this.state.getProp(MRCompactor.COMPACTION_DEST_DIR);
+ String tmpDir = ".temp";
Review comment:
Can we put this on ConfigurationKeys as a default, and possibly use this
with the other configurations `STAGING_DIR_DEFAULT_SUFFIX`,
`OUTPUT_DIR_DEFAULT_SUFFIX`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 611014)
Time Spent: 20m (was: 10m)
> Use "gobblin.useDatasetLocalWorkDir" to toggle creation of compaction MR out
> dir
> --------------------------------------------------------------------------------
>
> Key: GOBBLIN-1472
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1472
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
