[
https://issues.apache.org/jira/browse/GOBBLIN-1459?focusedWorklogId=611454&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-611454
]
ASF GitHub Bot logged work on GOBBLIN-1459:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/21 16:46
Start Date: 15/Jun/21 16:46
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#3298:
URL: https://github.com/apache/gobblin/pull/3298#discussion_r651971999
##########
File path:
gobblin-metastore/src/main/java/org/apache/gobblin/metastore/MysqlJobStatusStateStore.java
##########
@@ -70,6 +71,21 @@ public MysqlJobStatusStateStore(DataSource dataSource,
String stateStoreTableNam
return getAll(storeName, flowExecutionId + "%", true);
}
+ @Override
+ protected String getCreateJobStateTableTemplate() {
Review comment:
FYI, I added a test in other module to test long names when creating
spec with invalid names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 611454)
Time Spent: 2.5h (was: 2h 20m)
> correct column length in MysqlSpecStore, MysqlDagStore, MysqlJobStatusStore
> ---------------------------------------------------------------------------
>
> Key: GOBBLIN-1459
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1459
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> some column length in MysqlSpecStore, MysqlDagStore, MysqlJobStatusStore are
> incorrect. limit on these column lengths is decided by the limit on flow
> group and flow name limits
--
This message was sent by Atlassian Jira
(v8.3.4#803005)