[
https://issues.apache.org/jira/browse/GOBBLIN-1477?focusedWorklogId=613731&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-613731
]
ASF GitHub Bot logged work on GOBBLIN-1477:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jun/21 22:37
Start Date: 22/Jun/21 22:37
Worklog Time Spent: 10m
Work Description: codecov-commenter edited a comment on pull request
#3316:
URL: https://github.com/apache/gobblin/pull/3316#issuecomment-864329625
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3316?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3316](https://codecov.io/gh/apache/gobblin/pull/3316?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(6ccd416) into
[master](https://codecov.io/gh/apache/gobblin/commit/bf37c76f6da228ae96b0c405d184617f03d2c198?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(bf37c76) will **decrease** coverage by `0.21%`.
> The diff coverage is `76.47%`.
[](https://codecov.io/gh/apache/gobblin/pull/3316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3316 +/- ##
============================================
- Coverage 46.50% 46.28% -0.22%
+ Complexity 10041 3044 -6997
============================================
Files 2041 640 -1401
Lines 79349 24980 -54369
Branches 8845 2986 -5859
============================================
- Hits 36898 11563 -25335
+ Misses 39020 12168 -26852
+ Partials 3431 1249 -2182
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/gobblin/pull/3316/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh)
| `0.00% <ø> (ø)` | |
|
[...blin/service/modules/orchestration/DagManager.java](https://codecov.io/gh/apache/gobblin/pull/3316/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXIuamF2YQ==)
| `72.68% <76.47%> (-0.30%)` | :arrow_down: |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/gobblin/pull/3316/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `32.23% <0.00%> (-5.79%)` | :arrow_down: |
|
[.../converter/avro/AvroToJsonStringConverterBase.java](https://codecov.io/gh/apache/gobblin/pull/3316/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXZyby1qc29uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9hdnJvL0F2cm9Ub0pzb25TdHJpbmdDb252ZXJ0ZXJCYXNlLmphdmE=)
| | |
|
[.../retention/version/finder/SingleVersionFinder.java](https://codecov.io/gh/apache/gobblin/pull/3316/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3JldGVudGlvbi92ZXJzaW9uL2ZpbmRlci9TaW5nbGVWZXJzaW9uRmluZGVyLmphdmE=)
| | |
|
[...bblin/writer/http/UnexpectedResponseException.java](https://codecov.io/gh/apache/gobblin/pull/3316/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9odHRwL1VuZXhwZWN0ZWRSZXNwb25zZUV4Y2VwdGlvbi5qYXZh)
| | |
|
[...ata/management/copy/hive/HiveCopyEntityHelper.java](https://codecov.io/gh/apache/gobblin/pull/3316/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9IaXZlQ29weUVudGl0eUhlbHBlci5qYXZh)
| | |
|
[...earch/typemapping/AvroGenericRecordTypeMapper.java](https://codecov.io/gh/apache/gobblin/pull/3316/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3R5cGVtYXBwaW5nL0F2cm9HZW5lcmljUmVjb3JkVHlwZU1hcHBlci5qYXZh)
| | |
|
[...org/apache/gobblin/runtime/util/ClustersNames.java](https://codecov.io/gh/apache/gobblin/pull/3316/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdXRpbC9DbHVzdGVyc05hbWVzLmphdmE=)
| | |
|
[...runtime/mapreduce/GobblinWorkUnitsInputFormat.java](https://codecov.io/gh/apache/gobblin/pull/3316/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvZ29iYmxpbi9ydW50aW1lL21hcHJlZHVjZS9Hb2JibGluV29ya1VuaXRzSW5wdXRGb3JtYXQuamF2YQ==)
| | |
| ... and [1396
more](https://codecov.io/gh/apache/gobblin/pull/3316/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3316?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3316?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[1e03329...6ccd416](https://codecov.io/gh/apache/gobblin/pull/3316?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 613731)
Time Spent: 40m (was: 0.5h)
> Add code coverage and improve github actions pipeline
> -----------------------------------------------------
>
> Key: GOBBLIN-1477
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1477
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Fix bugs with static checking not working
> Add concurrency check so that a single PR cannot run multiple CI runs at the
> same time
> Add check to ensure git credentials are not persisted
> Add codecov back
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
