[
https://issues.apache.org/jira/browse/GOBBLIN-1478?focusedWorklogId=614146&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-614146
]
ASF GitHub Bot logged work on GOBBLIN-1478:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jun/21 17:42
Start Date: 23/Jun/21 17:42
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#3318:
URL: https://github.com/apache/gobblin/pull/3318#discussion_r657327595
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -1275,20 +1275,18 @@ public void run() {
try {
log.info("Cleaning failed dag state store");
long startTime = System.currentTimeMillis();
- List<String> dagIdsToClean = new ArrayList<>();
+ int numCleaned = 0;
- for (String dagId : this.failedDagIds) {
+ Set<String> failedDagIdsCopy = new HashSet<>(this.failedDagIds);
Review comment:
as per the
[doc](https://docs.oracle.com/javase/7/docs/api/java/util/Collections.html#synchronizedSet(java.util.Set))
, `synchronized` could have been used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 614146)
Time Spent: 40m (was: 0.5h)
> Fix concurrency issue when iterating failedDagIds
> -------------------------------------------------
>
> Key: GOBBLIN-1478
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1478
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
