Will-Lo commented on a change in pull request #3319:
URL: https://github.com/apache/gobblin/pull/3319#discussion_r657360705
##########
File path:
gobblin-modules/gobblin-sql/src/main/java/org/apache/gobblin/source/jdbc/JdbcExtractor.java
##########
@@ -959,6 +959,10 @@ public long getCount(CommandOutput<?, ?> response) throws
RecordCountException {
int batchSize =
this.workUnitState.getPropAsInt(ConfigurationKeys.SOURCE_QUERYBASED_FETCH_SIZE,
0);
batchSize = (batchSize == 0 ?
ConfigurationKeys.DEFAULT_SOURCE_FETCH_SIZE : batchSize);
+ String sourceConnProps =
this.workUnitState.getProp(ConfigurationKeys.SOURCE_CONN_PROPERTIES);
+ boolean convertZeroDateTimeToNull = sourceConnProps != null
Review comment:
I think here we can generalize this a bit more rather than keep it only
to the zeroDateTime behavior, to support the other zeroDateTime properties if
there are any users. We can check that sourceConnProps contains
zeroDateTimeBehavior, then parse it as timestamp and return the result. This
way it can handle the `ROUND` case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
