[
https://issues.apache.org/jira/browse/GOBBLIN-1481?focusedWorklogId=615864&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-615864
]
ASF GitHub Bot logged work on GOBBLIN-1481:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jun/21 22:08
Start Date: 28/Jun/21 22:08
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on pull request #3321:
URL: https://github.com/apache/gobblin/pull/3321#issuecomment-870077644
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3321?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3321](https://codecov.io/gh/apache/gobblin/pull/3321?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(8e727b4) into
[master](https://codecov.io/gh/apache/gobblin/commit/2407be647d3073063c4b589e656cf53f439aca8b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(2407be6) will **increase** coverage by `4.38%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/gobblin/pull/3321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3321 +/- ##
============================================
+ Coverage 46.41% 50.79% +4.38%
+ Complexity 10004 5517 -4487
============================================
Files 2031 1012 -1019
Lines 79002 38607 -40395
Branches 8834 4327 -4507
============================================
- Hits 36668 19612 -17056
+ Misses 38932 17289 -21643
+ Partials 3402 1706 -1696
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...vice/modules/dataset/FSDatasetPartitionConfig.java](https://codecov.io/gh/apache/gobblin/pull/3321/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9kYXRhc2V0L0ZTRGF0YXNldFBhcnRpdGlvbkNvbmZpZy5qYXZh)
| | |
|
[.../apache/gobblin/service/GroupOwnershipService.java](https://codecov.io/gh/apache/gobblin/pull/3321/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9Hcm91cE93bmVyc2hpcFNlcnZpY2UuamF2YQ==)
| | |
|
[...che/gobblin/compliance/HiveProxyQueryExecutor.java](https://codecov.io/gh/apache/gobblin/pull/3321/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY29tcGxpYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9jb21wbGlhbmNlL0hpdmVQcm94eVF1ZXJ5RXhlY3V0b3IuamF2YQ==)
| | |
|
[...ore/util/DatabaseJobHistoryStoreSchemaManager.java](https://codecov.io/gh/apache/gobblin/pull/3321/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL3V0aWwvRGF0YWJhc2VKb2JIaXN0b3J5U3RvcmVTY2hlbWFNYW5hZ2VyLmphdmE=)
| | |
|
[.../org/apache/gobblin/writer/WriterOutputFormat.java](https://codecov.io/gh/apache/gobblin/pull/3321/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1dyaXRlck91dHB1dEZvcm1hdC5qYXZh)
| | |
|
[.../gobblin/util/request\_allocation/ResourcePool.java](https://codecov.io/gh/apache/gobblin/pull/3321/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvcmVxdWVzdF9hbGxvY2F0aW9uL1Jlc291cmNlUG9vbC5qYXZh)
| | |
|
[...n/java/org/apache/gobblin/util/logs/LogCopier.java](https://codecov.io/gh/apache/gobblin/pull/3321/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbG9ncy9Mb2dDb3BpZXIuamF2YQ==)
| | |
|
[...obblin/broker/ImmediatelyInvalidResourceEntry.java](https://codecov.io/gh/apache/gobblin/pull/3321/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2Jyb2tlci9JbW1lZGlhdGVseUludmFsaWRSZXNvdXJjZUVudHJ5LmphdmE=)
| | |
|
[...bblin/metadata/types/GlobalMetadataJsonMerger.java](https://codecov.io/gh/apache/gobblin/pull/3321/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tbWV0YWRhdGEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YWRhdGEvdHlwZXMvR2xvYmFsTWV0YWRhdGFKc29uTWVyZ2VyLmphdmE=)
| | |
|
[...bblin/metastore/predicates/StoreNamePredicate.java](https://codecov.io/gh/apache/gobblin/pull/3321/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL3ByZWRpY2F0ZXMvU3RvcmVOYW1lUHJlZGljYXRlLmphdmE=)
| | |
| ... and [1008
more](https://codecov.io/gh/apache/gobblin/pull/3321/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3321?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3321?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[2407be6...8e727b4](https://codecov.io/gh/apache/gobblin/pull/3321?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 615864)
Time Spent: 20m (was: 10m)
> Exceptions caught when generating filesets for workunits is not propagated to
> a job failure
> -------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1481
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1481
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: William Lo
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When encountering an error during fileset generation, Gobblin will catch and
> log the errors but not fail the job. Since no workunits are generated in this
> scenario, we should just throw an exception here and fail the job.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
