aplex commented on a change in pull request #3334:
URL: https://github.com/apache/gobblin/pull/3334#discussion_r672598289
##########
File path:
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java
##########
@@ -496,6 +496,7 @@
public static final String DATA_PUBLISHER_OVERWRITE_ENABLED =
DATA_PUBLISHER_PREFIX + ".overwrite.enabled";
// This property is used to specify the owner group of the data publisher
final output directory
public static final String DATA_PUBLISHER_FINAL_DIR_GROUP =
DATA_PUBLISHER_PREFIX + ".final.dir.group";
+ public static final String DATA_PUBLISHER_OUTPUT_DIR_GROUP =
DATA_PUBLISHER_PREFIX + ".output.dir.group";
Review comment:
Discussed over the chat. The summary is that the old setting works
incorrectly, but even if it would work correctly, it would not be what we need.
From vbohra:
so the publisherOutputDir can be the following based on use case
- data.publisher.final.dir ( if data.publisher.appendExtractToFinalDir is
set to false)
- data.publisher.final.dir/db/table ( if
data.publisher.appendExtractToFinalDir is set to true and writer.file.path.type
= namespace_table) [ THIS IS THE CASE FOR brooklin-etl ]
- data.publisher.final.dir/table ( if data.publisher.appendExtractToFinalDir
is set to true and writer.file.path.type = tablename)
- and a default
##########
File path:
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java
##########
@@ -496,6 +496,7 @@
public static final String DATA_PUBLISHER_OVERWRITE_ENABLED =
DATA_PUBLISHER_PREFIX + ".overwrite.enabled";
// This property is used to specify the owner group of the data publisher
final output directory
public static final String DATA_PUBLISHER_FINAL_DIR_GROUP =
DATA_PUBLISHER_PREFIX + ".final.dir.group";
+ public static final String DATA_PUBLISHER_OUTPUT_DIR_GROUP =
DATA_PUBLISHER_PREFIX + ".output.dir.group";
Review comment:
Discussed over the chat. The summary is that the old setting works
incorrectly, but even if it would work correctly, it would not be what we need.
From vikrambohra:
so the publisherOutputDir can be the following based on use case
- data.publisher.final.dir ( if data.publisher.appendExtractToFinalDir is
set to false)
- data.publisher.final.dir/db/table ( if
data.publisher.appendExtractToFinalDir is set to true and writer.file.path.type
= namespace_table) [ THIS IS THE CASE FOR brooklin-etl ]
- data.publisher.final.dir/table ( if data.publisher.appendExtractToFinalDir
is set to true and writer.file.path.type = tablename)
- and a default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]