Will-Lo commented on a change in pull request #3335:
URL: https://github.com/apache/gobblin/pull/3335#discussion_r674584137
##########
File path:
gobblin-utility/src/main/java/org/apache/gobblin/util/ConfigUtils.java
##########
@@ -116,7 +116,8 @@ public static Properties configToProperties(Config config,
Optional<String> pref
Config resolvedConfig = config.resolve();
for (Map.Entry<String, ConfigValue> entry : resolvedConfig.entrySet()) {
if (!prefix.isPresent() || entry.getKey().startsWith(prefix.get())) {
- String propKey = desanitizeKey(entry.getKey());
+ // Intern the string so that constant keys are not duplicated to
save memory
+ String propKey = desanitizeKey(entry.getKey()).intern();
Review comment:
Ah you're right it would create a new one, I misunderstood some of the
underlying risks of intern() 😄 . Doing some more reading, it does have some
risks if there are a number of unique values though. Given that there are many
values that are unique in key vals for configs, it might lead to other issues
moreso than keys, like affecting the permanent memory pool size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
