[
https://issues.apache.org/jira/browse/GOBBLIN-1492?focusedWorklogId=626478&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626478
]
ASF GitHub Bot logged work on GOBBLIN-1492:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jul/21 08:07
Start Date: 22/Jul/21 08:07
Worklog Time Spent: 10m
Work Description: Will-Lo commented on a change in pull request #3335:
URL: https://github.com/apache/gobblin/pull/3335#discussion_r674584137
##########
File path:
gobblin-utility/src/main/java/org/apache/gobblin/util/ConfigUtils.java
##########
@@ -116,7 +116,8 @@ public static Properties configToProperties(Config config,
Optional<String> pref
Config resolvedConfig = config.resolve();
for (Map.Entry<String, ConfigValue> entry : resolvedConfig.entrySet()) {
if (!prefix.isPresent() || entry.getKey().startsWith(prefix.get())) {
- String propKey = desanitizeKey(entry.getKey());
+ // Intern the string so that constant keys are not duplicated to
save memory
+ String propKey = desanitizeKey(entry.getKey()).intern();
Review comment:
Ah you're right it would create a new one, I misunderstood some of the
underlying risks of intern() 😄 . Doing some more reading, it does have some
risks if there are a number of unique values though. Given that there are many
values that are unique in key vals for configs, it might lead to other issues
moreso than keys, like affecting the permanent memory pool size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 626478)
Time Spent: 1h 40m (was: 1.5h)
> Optimize memory usage for Gobblin as a Service
> ----------------------------------------------
>
> Key: GOBBLIN-1492
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1492
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Gobblin as a Service, under high loads, spends a large amount of time garbage
> collecting. This will track a number of changes relating to optimizing the
> memory usage
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
