[
https://issues.apache.org/jira/browse/GOBBLIN-1495?focusedWorklogId=628156&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-628156
]
ASF GitHub Bot logged work on GOBBLIN-1495:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jul/21 05:30
Start Date: 27/Jul/21 05:30
Worklog Time Spent: 10m
Work Description: codecov-commenter edited a comment on pull request
#3341:
URL: https://github.com/apache/gobblin/pull/3341#issuecomment-887219858
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3341?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3341](https://codecov.io/gh/apache/gobblin/pull/3341?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(f9d6768) into
[master](https://codecov.io/gh/apache/gobblin/commit/c65e5d05f24eb2f7f643c67abbdf0171939072bc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(c65e5d0) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/gobblin/pull/3341?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3341 +/- ##
============================================
- Coverage 46.55% 46.54% -0.01%
+ Complexity 10140 10138 -2
============================================
Files 2052 2052
Lines 79557 79559 +2
Branches 8882 8883 +1
============================================
- Hits 37035 37030 -5
- Misses 39092 39101 +9
+ Partials 3430 3428 -2
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3341?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...ava/org/apache/gobblin/util/hadoop/TokenUtils.java](https://codecov.io/gh/apache/gobblin/pull/3341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvaGFkb29wL1Rva2VuVXRpbHMuamF2YQ==)
| `0.00% <0.00%> (ø)` | |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/gobblin/pull/3341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `32.23% <0.00%> (-5.79%)` | :arrow_down: |
|
[...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/gobblin/pull/3341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==)
| `29.93% <0.00%> (-0.66%)` | :arrow_down: |
|
[.../modules/scheduler/GobblinServiceJobScheduler.java](https://codecov.io/gh/apache/gobblin/pull/3341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zY2hlZHVsZXIvR29iYmxpblNlcnZpY2VKb2JTY2hlZHVsZXIuamF2YQ==)
| `59.89% <0.00%> (+1.04%)` | :arrow_up: |
|
[...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3341/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh)
| `62.36% <0.00%> (+2.15%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3341?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3341?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[c65e5d0...f9d6768](https://codecov.io/gh/apache/gobblin/pull/3341?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 628156)
Time Spent: 50m (was: 40m)
> NPE when trying to fetch Hadoop tokens for cluster with no remote namenodes
> ---------------------------------------------------------------------------
>
> Key: GOBBLIN-1495
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1495
> Project: Apache Gobblin
> Issue Type: Bug
> Affects Versions: 0.15.0
> Reporter: Dushyant Kumar
> Assignee: Abhishek Tiwari
> Priority: Critical
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When the application tries to fetch Hadoop tokens for a cluster with no
> remote namenodes, the current implementation of getHadoopTokens method
> doesn't check for the property "other_namenodes" while getting
> remoteFSURIList. This property is not mandatory and won't be present if there
> are not remote namenodes. In such cases, it throws NPE.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
