[
https://issues.apache.org/jira/browse/GOBBLIN-1497?focusedWorklogId=628726&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-628726
]
ASF GitHub Bot logged work on GOBBLIN-1497:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jul/21 21:26
Start Date: 27/Jul/21 21:26
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on pull request #3340:
URL: https://github.com/apache/gobblin/pull/3340#issuecomment-887846190
minor comments to simply things. LGTM otherwise. good changes. maybe we
should get rid of configAsProperties entirely. but that may need more changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 628726)
Time Spent: 2h (was: 1h 50m)
> Reduce the number of calls to create FlowSpecs and configToProperties
> ---------------------------------------------------------------------
>
> Key: GOBBLIN-1497
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1497
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> FlowSpecs contain both configs and property fields that duplicate the same
> key/value information, however there are slight differences with properties
> being mutable, configs being type-safe, and legacy code being compatible with
> properties but not configs.
> As such, FlowSpec creation and configToProperties are memory expensive
> operations at scale, and we should aim to minimize them as much as possible.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
