[ 
https://issues.apache.org/jira/browse/GOBBLIN-1501?focusedWorklogId=631857&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-631857
 ]

ASF GitHub Bot logged work on GOBBLIN-1501:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Jul/21 19:31
            Start Date: 30/Jul/21 19:31
    Worklog Time Spent: 10m 
      Work Description: autumnust opened a new pull request #3347:
URL: https://github.com/apache/gobblin/pull/3347


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - https://issues.apache.org/jira/browse/GOBBLIN-1501
   
   
   ### Description
   This PR mostly adds documentation, renaming and fixing typo in the 
`gobblin-icberg` module, with extra focus on `IcebergMetadataWriter` for: 
   - Change the way that `Transaction` object is initialized as it is shared in 
many different places. 
   - Change the way for accessing or initializing `AppendFiles` and 
`DeleteFiles` object. All these changes in `TableMetadata` object. 
   - Adding documentation for places where commit does happen or doesn't happen 
for reasons. 
   - Remove some of the `IOException` in the method signature wherever they are 
not required. 
   
   
   
   
   ### Tests
   This PR doesn't add or delete any of the functionality so pass all unit 
tests should be sufficient. 
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

            Worklog Id:     (was: 631857)
    Remaining Estimate: 0h
            Time Spent: 10m

> IcebergMetadataWriter Documentation and cleanup
> -----------------------------------------------
>
>                 Key: GOBBLIN-1501
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1501
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Lei Sun
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to