[
https://issues.apache.org/jira/browse/GOBBLIN-1500?focusedWorklogId=632592&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-632592
]
ASF GitHub Bot logged work on GOBBLIN-1500:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Aug/21 20:19
Start Date: 02/Aug/21 20:19
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on a change in pull request #3345:
URL: https://github.com/apache/gobblin/pull/3345#discussion_r681245048
##########
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
##########
@@ -574,19 +592,21 @@ private String sanitizeApplicationId(String
applicationId) {
@VisibleForTesting
Optional<ApplicationId> getReconnectableApplicationId() throws
YarnException, IOException {
- List<ApplicationReport> applicationReports =
- this.yarnClient.getApplications(APPLICATION_TYPES,
RECONNECTABLE_APPLICATION_STATES);
- if (applicationReports == null || applicationReports.isEmpty()) {
- return Optional.absent();
- }
+ for (YarnClient yarnClient: potentialYarnClients.values()) {
+ List<ApplicationReport> applicationReports =
yarnClient.getApplications(APPLICATION_TYPES, RECONNECTABLE_APPLICATION_STATES);
+ if (applicationReports == null || applicationReports.isEmpty()) {
+ continue;
+ }
- // Try to find an application with a matching application name
- for (ApplicationReport applicationReport : applicationReports) {
- if (this.applicationName.equals(applicationReport.getName())) {
- String applicationId =
sanitizeApplicationId(applicationReport.getApplicationId().toString());
- LOGGER.info("Found reconnectable application with application ID: " +
applicationId);
- LOGGER.info("Application Tracking URL: " +
applicationReport.getTrackingUrl());
- return Optional.of(applicationReport.getApplicationId());
+ // Try to find an application with a matching application name
+ for (ApplicationReport applicationReport : applicationReports) {
Review comment:
yeah, in that case, we will continue to check next potential clusters,
and if we found nothing in all clusters, we will return Optional.absent on line
613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 632592)
Time Spent: 1h 10m (was: 1h)
> Support gobblin on yarn to be able to run on clusters with robin enabled
> ------------------------------------------------------------------------
>
> Key: GOBBLIN-1500
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1500
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Previously we always check with one default yarn client, but if the cluster
> is enabled with Robin and can connect to different RM, it will ends up we
> cannot find existing application and submit duplicate tasks. So now we need
> to check against different potential yarn cluster, and also make sure when
> submitting yarn application, we only have one RM token.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
