[
https://issues.apache.org/jira/browse/GOBBLIN-1503?focusedWorklogId=633176&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633176
]
ASF GitHub Bot logged work on GOBBLIN-1503:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Aug/21 21:33
Start Date: 03/Aug/21 21:33
Worklog Time Spent: 10m
Work Description: jack-moseley opened a new pull request #3348:
URL: https://github.com/apache/gobblin/pull/3348
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1503
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
If mysql db enters read-only mode due to a failover, the connections need to
be reset before writes will work. Currently the validation query is "select 1",
so it will not evict connections in read-only mode. This new query is taken
from
https://stackoverflow.com/questions/39552146/evicting-connections-to-a-read-only-node-in-a-cluster-from-the-connection-pool,
and should fail the validation if the db is read-only, so connections will be
retried.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Tested that query succeeded on a non-read only mysql db.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 633176)
Remaining Estimate: 0h
Time Spent: 10m
> Modify mysql validation query to fail if db is in read-only mode
> ----------------------------------------------------------------
>
> Key: GOBBLIN-1503
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1503
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)